Add retries to SCPMover.copy() #153
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TAlonglong
reviewed
Jan 22, 2023
trollmoves/movers.py
Outdated
| scp = self._get_scp_client() | ||
| scp.put(self.origin, self.destination.path) | ||
| success = True | ||
| break |
There was a problem hiding this comment.
Do you need the break here if you break on success further down?
There was a problem hiding this comment.
I was already pretty tired when writing that, so probably not 😅
I think we can keep the timeout option, too. |
Codecov Report
@@ Coverage Diff @@
## main #153 +/- ##
==========================================
+ Coverage 88.37% 88.55% +0.18%
==========================================
Files 22 22
Lines 4437 4492 +55
==========================================
+ Hits 3921 3978 +57
+ Misses 516 514 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds retries to the
SCPMover.copy()method. Currently there's only retries in creating the connection.VERY early work.
AUTHORS.mdif not there already